feat(css): add new utility-classes #30186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenOsodrac
added
type: feature request
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
reviewed
Feb 12, 2025
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
Since these appear to be more directed towards the ionic theme, it might be best to move them to the css/ionic folder. Why are they being added to core?
Contributor
Author
The request come from the Ionic theme context yes, but I its all classes related to agnostic/normal css rules, that I see no problem adding to the common context, as some of them, like the flex ones, are just an extension of the existing offering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
What is the new behavior?
Added new utility-classes related to:
Does this introduce a breaking change?
Other information